Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ControlGallery #27039

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Remove ControlGallery #27039

merged 1 commit into from
Jan 14, 2025

Conversation

jfversluis
Copy link
Member

@jfversluis jfversluis commented Jan 9, 2025

Description of Change

Now that we have (almost) ported all Xamarin.UITests to Appium, we can remove the legacy ControlGallery UI tests sample app. This PR does that. It removes the code itself as well as all references to it in the build scripts.

@jfversluis jfversluis added t/housekeeping ♻︎ area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions labels Jan 9, 2025
@Copilot Copilot bot review requested due to automatic review settings January 9, 2025 15:48
@jfversluis jfversluis requested a review from a team as a code owner January 9, 2025 15:48

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2788 out of 2803 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • eng/pipelines/common/ui-tests-compatibility-steps.yml: Language not supported
  • src/Compatibility/ControlGallery/src/Android/Assets/default.css: Language not supported
  • src/Compatibility/ControlGallery/src/Android/Assets/fonts/icons.xml: Language not supported
  • src/Compatibility/ControlGallery/src/Android/Assets/googlemap.html: Language not supported
  • src/Compatibility/ControlGallery/src/Android/Assets/googlemapsearch.html: Language not supported
  • src/Compatibility/ControlGallery/src/Android/Assets/local.html: Language not supported
  • src/Compatibility/ControlGallery/src/Android/Compatibility.ControlGallery.Android.csproj: Language not supported
  • src/Compatibility/ControlGallery/src/Android/BrokenNativeControl.cs: Evaluated as low risk
  • src/Compatibility/ControlGallery/src/Android/Activity1.cs: Evaluated as low risk
  • src/Compatibility/ControlGallery/src/Android/AttachedStateEffectRenderer.cs: Evaluated as low risk
  • src/Compatibility/ControlGallery/src/Android/BorderEffect.cs: Evaluated as low risk
  • src/Compatibility/ControlGallery/src/Android/CacheService.cs: Evaluated as low risk
  • src/Compatibility/ControlGallery/src/Android/ColorPicker.cs: Evaluated as low risk
  • src/Compatibility/ControlGallery/src/Android/Compatibility/Activity1.cs: Evaluated as low risk
  • eng/devices/android.cake: Evaluated as low risk
@jfversluis jfversluis marked this pull request as draft January 9, 2025 15:51
@jfversluis jfversluis added this to the .NET 9 SR4 milestone Jan 13, 2025
@jfversluis jfversluis marked this pull request as ready for review January 13, 2025 15:26
@jfversluis jfversluis requested a review from PureWeen January 13, 2025 15:26
@jfversluis
Copy link
Member Author

/rebase

@github-actions github-actions bot force-pushed the remove-controlgallery branch from 355587f to ff788d5 Compare January 13, 2025 18:57
@jfversluis jfversluis merged commit 23bec7e into main Jan 14, 2025
104 checks passed
@jfversluis jfversluis deleted the remove-controlgallery branch January 14, 2025 14:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions t/housekeeping ♻︎
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants