-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Title doesn't visible when set IsVisible to true of ShellContent #26966
Conversation
Hey there @NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NirmalKumarYuvaraj can you look at just pulling @Foda 's PR into this one?
Since you've added tests here and we can see if that also resolves the issue?
Also, can you confirm if this also fixes
#19496
@PureWeen / @Foda, the changes proposed in PR #27151 address the issues reported in #19496 and #23214 (@Foda resolved this issue in PR #25479. PR #25479 (Foda's fix) resolved this by removing the measure and arrange overrides. However, this causes the margin values defined for items in the template to no longer apply. For instance, if those overrides are removed, the issue fixed in PR #27060 will break. Therefore, it is necessary to keep the measure and arrange overrides. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
|
Issue Details:
Title doesn't visible when set IsVisible to true of ShellContent on button click.
Root Cause:
Without calling base.MeasureOverride, the ShellFlyoutItemView (or its content) was not measured properly by the layout system. As a result, it was not sized at all, causing it to be invisible in the view.
Description of Change:
Added a call to base.MeasureOverride(availableSize) to ensure that the internal measurement logic provided by the base class is executed before measuring the custom view.
Tested the behavior in the following platforms.
Issues Fixed:
Fixes #19783
Fixes #19496
Screenshots