Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title doesn't visible when set IsVisible to true of ShellContent #26966

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

NirmalKumarYuvaraj
Copy link
Contributor

@NirmalKumarYuvaraj NirmalKumarYuvaraj commented Jan 6, 2025

Issue Details:

Title doesn't visible when set IsVisible to true of ShellContent on button click.

Root Cause:

Without calling base.MeasureOverride, the ShellFlyoutItemView (or its content) was not measured properly by the layout system. As a result, it was not sized at all, causing it to be invisible in the view.

Description of Change:

Added a call to base.MeasureOverride(availableSize) to ensure that the internal measurement logic provided by the base class is executed before measuring the custom view.

Tested the behavior in the following platforms.

  • Android
  • Windows
  • iOS
  • Mac

Issues Fixed:

Fixes #19783
Fixes #19496

Screenshots

Before Issue Fix After Issue Fix

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 6, 2025
Copy link
Contributor

Hey there @NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@karthikraja-arumugam karthikraja-arumugam added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 6, 2025
@jfversluis jfversluis added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label Jan 9, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@NirmalKumarYuvaraj NirmalKumarYuvaraj marked this pull request as ready for review January 16, 2025 08:46
@NirmalKumarYuvaraj NirmalKumarYuvaraj requested a review from a team as a code owner January 16, 2025 08:46
@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NirmalKumarYuvaraj can you look at just pulling @Foda 's PR into this one?

#25479

Since you've added tests here and we can see if that also resolves the issue?

Also, can you confirm if this also fixes
#19496

@Tamilarasan-Paranthaman
Copy link
Contributor

@NirmalKumarYuvaraj can you look at just pulling @Foda 's PR into this one?

#25479

Since you've added tests here and we can see if that also resolves the issue?

Also, can you confirm if this also fixes #19496

@PureWeen / @Foda, the changes proposed in PR #27151 address the issues reported in #19496 and #23214 (@Foda resolved this issue in PR #25479.

PR #25479 (Foda's fix) resolved this by removing the measure and arrange overrides. However, this causes the margin values defined for items in the template to no longer apply.

For instance, if those overrides are removed, the issue fixed in PR #27060 will break. Therefore, it is necessary to keep the measure and arrange overrides.

@StephaneDelcroix
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen added this to the .NET 9 SR4 milestone Jan 23, 2025
@PureWeen
Copy link
Member

  • failing test unrelated

@PureWeen PureWeen merged commit 92f25df into dotnet:main Jan 23, 2025
102 of 106 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
Status: Done
9 participants