Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for [Windows]ToolbarItem visibility until Page Disappearing #26915

Merged
merged 10 commits into from
Feb 7, 2025

Conversation

SuthiYuvaraj
Copy link
Contributor

Root Cause

When changing the Toolbar Item properties on Disappearing event , the Handler is removed in Toolbar as the items are updating on the disappearing event on windows platform

Description of Change

Handled the null possibility in OnToolbarItemPropertyChanged

Issues Fixed

Fixes #26803

Tested the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Output Video

Before Issue Fix After Issue Fix
Before Fix video
Recording.2024-12-27.132438.mp4

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 2, 2025
@karthikraja-arumugam karthikraja-arumugam added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 2, 2025
@SuthiYuvaraj SuthiYuvaraj marked this pull request as ready for review January 6, 2025 03:49
@SuthiYuvaraj SuthiYuvaraj requested a review from a team as a code owner January 6, 2025 03:49
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz jsuarezruiz self-requested a review January 14, 2025 11:10
@PureWeen PureWeen merged commit c205c84 into dotnet:main Feb 7, 2025
106 checks passed
@PureWeen PureWeen added this to the .NET 9 SR4 milestone Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-toolbar ToolBar community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
Status: Done
5 participants