Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Added DidPopItem to the navigation renderer #26235

Merged
merged 1 commit into from
Dec 9, 2024
Merged

[iOS] Added DidPopItem to the navigation renderer #26235

merged 1 commit into from
Dec 9, 2024

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Nov 29, 2024 •
edited
Loading

Issues Fixed

Fixes #26216

Before After
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-29.at.12.04.12.mp4
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-29.at.11.57.33.mp4

@kubaflo kubaflo requested a review from a team as a code owner November 29, 2024 11:08
@kubaflo kubaflo requested review from Eilon and rmarinho November 29, 2024 11:08
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Nov 29, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo added the area-navigation NavigationPage label Nov 29, 2024
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 29, 2024
@eth-ellis
Copy link
Contributor

@kubaflo Does this fix the linked issue?
The issue refers to navigating back by the user swiping, but the before and after videos above only show the back button being used.

@kubaflo
Copy link
Contributor Author

kubaflo commented Dec 2, 2024

@kubaflo Does this fix the linked issue? The issue refers to navigating back by the user swiping, but the before and after videos above only show the back button being used.

Yeah, I see, the simulator screed didn't capture my swipe gesture, but the first navigation back was performed using the swipe. However, I think it would be best if you also tried it with a build generated by this PR :)

@jfversluis
Copy link
Member

Could it be that you switched the videos for before and after? 😄

@jfversluis jfversluis added this to the .NET 9 SR3 milestone Dec 9, 2024
@jfversluis jfversluis merged commit c3f3e3d into dotnet:main Dec 9, 2024
104 checks passed
@kubaflo
Copy link
Contributor Author

kubaflo commented Dec 9, 2024

Could it be that you switched the videos for before and after? 😄

Oh yes, my bad😅

@kubaflo
Copy link
Contributor Author

kubaflo commented Dec 9, 2024

@jfversluis could you also please have a look at this one: #24003
It is very similar but for shell pages

@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
@Shalini-Ashokan Shalini-Ashokan mentioned this pull request Jan 9, 2025
Merged
4 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jfversluis jfversluis jfversluis approved these changes

@Eilon Eilon Awaiting requested review from Eilon Eilon is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-navigation NavigationPage community ✨ Community Contribution fixed-in-net8.0-nightly This may be available in a nightly release! fixed-in-net9.0-nightly This may be available in a nightly release! platform/iOS 🍎
Projects
None yet
Milestone
.NET 9 SR3
Development

Successfully merging this pull request may close these issues.

iOS - OnNavigatedFrom is not fired when navigating back by swiping
4 participants
@kubaflo @eth-ellis @jfversluis @samhouts