-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] [Mac] Fix for Gradient background size is incorrect when invalidating parent #26222
[iOS] [Mac] Fix for Gradient background size is incorrect when invalidating parent #26222
Conversation
Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Hi, @albyrock87 I remember you were making some changes to this viewExtension.cs when you were working on the border fix. Does this PR look good to you? |
@albyrock87 I see! Your PR is great! Maybe you should also include a UI test for this issue in your PR as well #24848 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 7 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- src/Controls/tests/TestCases.HostApp/Issues/Issue26057.xaml: Language not supported
Comments skipped due to low confidence (1)
src/Controls/tests/TestCases.HostApp/Issues/Issue26057.xaml.cs:16
- Ensure that 'stack' is properly defined and used within this context. The current snippet does not provide enough information about 'stack'.
(stack as IView).InvalidateMeasure();
I will add this UI test on my PR to confirm it fixes this issue too. |
@Tamilarasan-Paranthaman I've added you as co-author on #24848 where I've just included your UI test and verified it works fine |
Root Cause of the issue
Description of Change
Issues Fixed
Fixes #26057
Fixes #20218
Tested the behaviour in the following platforms
Screenshot
iOS
iOSGradientIssue.mov
iOSGradientFix.mov
Mac
MacGradientIssue.mov
MacGradientFix.mov