-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Tweener leak on Animation #26143
Conversation
Hey there @pictos! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we port the unit test to this PR too ?
@rmarinho the unit tests aren't related to this change. The The tests in previous PR are related to |
Co-authored-by: MartyIX <[email protected]>
Can we add a test to check the public Tweener leaks or not ? do we make s_tweeners internal ? |
Description of Change
This PR is a piece of #25232, that is a WiP to fix memories leaks on Animation.
This PR prevents the Tweener to live forever and the
s_tweeners
collection to grow forever.Issues Fixed
Fixes #25001