Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Enabling ported UITests from Xamarin.UITests to Appium #25711

Merged
merged 10 commits into from
Nov 11, 2024

Conversation

anandhan-rajagopal
Copy link
Contributor

Description of Change

This PR focuses on re-enabling and updating following tests from the Xamarin.UITest framework to be compatible with Appium. The tests, previously commented out, are reviewed, and modified to ensure they are functional with the Appium framework.

TestCases

  • Bugzilla25943
  • Issue12246
  • Bugzilla40858 - (Note: Ignored the MacCatalyst platform for this case due to the TouchAndHold action not functioning on Mac.)
  • Bugzilla43161

Copy link
Contributor

Hey there @anandhan-rajagopal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Nov 6, 2024
@jsuarezruiz jsuarezruiz added the area-testing Unit tests, device tests label Nov 6, 2024
[Category(UITestCategories.Compatibility)]
[FailsOnAndroidWhenRunningOnXamarinUITest]
[FailsOnIOSWhenRunningOnXamarinUITest]
[FailsOnMacWhenRunningOnXamarinUITest]
public void VerifyNestedStacklayoutTapsBubble()
{
App.WaitForElement(InnerLayout);
App.Tap(InnerLayout);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Methods like WaitForElement or Tap for example, search first by AutomationId and if don't find the element, make a query using XPath searching by content (text etc). In principle, it shouldn't be necessary to modify the test example by adding AutomationIds for it to work.

On the other hand, using AutomationId is more efficient than queries, so it's a good practice.

@dotnet dotnet deleted a comment from azure-pipelines bot Nov 6, 2024
@jfversluis jfversluis self-assigned this Nov 6, 2024
@anandhan-rajagopal
Copy link
Contributor Author

@dotnet-policy-service agree

@anandhan-rajagopal anandhan-rajagopal marked this pull request as ready for review November 6, 2024 14:26
@anandhan-rajagopal anandhan-rajagopal requested a review from a team as a code owner November 6, 2024 14:26
@PureWeen PureWeen added this to the .NET 9 SR2 milestone Nov 6, 2024
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 8, 2024
@jsuarezruiz
Copy link
Contributor

/rebase

@dotnet dotnet deleted a comment from azure-pipelines bot Nov 8, 2024
@github-actions github-actions bot force-pushed the enable-xamarinuitests branch from b75beb1 to b892859 Compare November 8, 2024 11:44
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

  • failing template test unrelated

@PureWeen PureWeen merged commit 8b96f6d into dotnet:main Nov 11, 2024
105 of 107 checks passed
@anandhan-rajagopal anandhan-rajagopal added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests community ✨ Community Contribution fixed-in-9.0.21 partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants