-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Fix for Editor scaling creating new lines on older iOS versions #25691
Conversation
Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/rebase |
e84d085
to
a31e97e
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failing on winui
@PureWeen, I have added the snapshot for WinUI. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The device tests:
ScrollEditor
Assert.True() Failure\nExpected: True\nActual: False
and
ScrollNextEditor
Assert.True() Failure\nExpected: True\nActual: False
are failing after the changes.
@jsuarezruiz, I have fixed this by restricting the Mac platform in the fix, as the issue occurred on the iOS platform. The cases have passed locally. Could you please check and let me know if you have any concerns? ![]() |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@Tamilarasan-Paranthaman did you see this issue in iOS 17? I have only noticed it in 15.5 and 16.4 but maybe there is a scenario it happens in 17 also? |
@tj-devel709, I encountered this issue in iOS 17+ as well. Interestingly, I am currently unable to reproduce it in iOS 17+ (specifically tested on version 17.5). This is quite unusual, as the issue report also confirms it was verified in version 17.5. Could you please share your thoughts on this and suggest how we should proceed? |
@Tamilarasan-Paranthaman let's just go with what you're seeing Can you just set the operating system version check to whatever version you find that we need this for? |
@PureWeen, I have updated the version, and it will now apply only to versions below 17. Could you please check it now and let me know if you have any further concerns? |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed with these new changes that it works with the following I versions!
18.1
18.0
17.5
17.2
17.01
16.4
15.5
Root Cause of the issue
Description of Change
Issues Fixed
Fixes #25581
Tested the behaviour in the following platforms
Screenshot
Issue.mov
Fix.mov