Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear out prototype cell when changing ItemSource #24700

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Clear out prototype cell when changing ItemSource #24700

merged 3 commits into from
Sep 11, 2024

Conversation

PureWeen
Copy link
Member

Description of Change

When converting ListView over to handler architecture we incorrectly commented out the code that would reset the prototype cell when the item source changed. This now causes issues with the prototype cell being reused and the datatemplate selector is being changed out

Issues Fixed

Fixes #20261

@PureWeen PureWeen requested a review from a team as a code owner September 10, 2024 21:09
Redth
Redth previously approved these changes Sep 10, 2024
View reviewed changes
rmarinho
rmarinho previously approved these changes Sep 10, 2024
View reviewed changes
@PureWeen PureWeen dismissed stale reviews from rmarinho and Redth via 744de28 September 10, 2024 21:45
@PureWeen PureWeen changed the title Clear out prototype cell which changing ItemSource Clear out prototype cell when changing ItemSource Sep 10, 2024
@PureWeen PureWeen mentioned this pull request Sep 10, 2024
Closed
@PureWeen PureWeen added this to the .NET 8 SR9 milestone Sep 11, 2024
@mattleibow mattleibow added the area-controls-listview ListView and TableView label Sep 11, 2024
@PureWeen
Copy link
Member Author

  • Catalyst is currently having issues installing .NET. These tests passed on iOS so these changes are good to go as far as iOS is concerned.
  • Template tests won't be involved with these changes

@PureWeen PureWeen merged commit fd718a1 into main Sep 11, 2024
86 of 97 checks passed
@PureWeen PureWeen deleted the fix_20261 branch September 11, 2024 23:17
@BagavathiPerumal BagavathiPerumal mentioned this pull request Sep 18, 2024
Merged
4 tasks
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Oct 1, 2024
@samhouts samhouts added fixed-in-9.0.0-rc.2.24503.2 and removed fixed-in-net9.0-nightly This may be available in a nightly release! labels Oct 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Redth Redth Redth approved these changes

@mattleibow mattleibow mattleibow approved these changes

@rmarinho rmarinho rmarinho approved these changes

@Eilon Eilon Awaiting requested review from Eilon Eilon is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-controls-listview ListView and TableView fixed-in-9.0.0-rc.2.24503.2
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 8 SR9
Development

Successfully merging this pull request may close these issues.

ListView + DataTemplateSelector + HasUnevenRows issue on iOS
5 participants
@PureWeen @Redth @mattleibow @rmarinho @samhouts