Fix cake scripts to work locally #24111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
commented
Aug 8, 2024
| @@ -0,0 +1,13 @@ | |||
| #load "../cake/helpers.cake" | |||
|
|
|||
| if (!IsCIBuild() && GetBuildVariable("workloads", "notset") == "notset") | |||
There was a problem hiding this comment.
For UI tests lets just default to global workloads for now. I think we should just make this change everywhere. This isn't really a scenario that most users care about anymore.
PureWeen
commented
Aug 8, 2024
eng/devices/ios.cake
Outdated
| var simXH = sims.Where(s => s.Name.Contains(simulatorName) && s.Name.Contains(iosVersionToRun)).FirstOrDefault(); | ||
| if (simXH == null) | ||
| throw new Exception("No simulator was found to run tests on."); | ||
| { | ||
| // if the device is already installed on this system then xharness won't create a new one |
There was a problem hiding this comment.
This code is a little bit awkward.
I found that if you already have a device that's "iPhone Xs 17.2" installed. Xharness won't create a new device and then this code just fails because it can't find something called "Xharness"
Is there a way to get the UDID from the xharness script above?
PureWeen
commented
Aug 8, 2024
PureWeen
force-pushed
the
fix_local_cake
branch
from
483a5b0 to
b2f7f9f
Compare
rmarinho
reviewed
Aug 14, 2024
|
Just tested this with Android with the commands provided in the OP and it just worked! 🤯 |
PureWeen
force-pushed
the
fix_local_cake
branch
from
b2f7f9f to
c0abbf9
Compare
|
/rebase |
github-actions
bot
force-pushed
the
fix_local_cake
branch
from
c0abbf9 to
46cd5d1
Compare
mattleibow
approved these changes
Aug 16, 2024
|
Failing windows device test is unrelated |
samhouts
added
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The UITest scripts aren't really working so well when ran locally. This PR fixes them and attempts to make it so they are overall much easier to run.
I've made comments to the various parts of the changes with thoughts/questions
Basically, this PR gets us to the point where you can do
Additional thoughts
VerifyScreenshotcode to detect the right device when running fromtest explorer. TheDevice Namedoesn't really get passed up into Appium. A bunch of the capabilities get passed in, so, maybe we can just make sure the viewport and various other values match with what our screenshots are using