Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Update packages System.Drawing #22691

Merged
merged 1 commit into from
May 28, 2024
Merged

[ci] Update packages System.Drawing #22691

merged 1 commit into from
May 28, 2024

Conversation

rmarinho
Copy link
Member

Description of Change

Updates for CG

@rmarinho rmarinho added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label May 28, 2024
@rmarinho rmarinho requested a review from mattleibow May 28, 2024 18:19
@rmarinho rmarinho requested a review from a team as a code owner May 28, 2024 18:19
@rmarinho rmarinho requested a review from Eilon May 28, 2024 18:19
@@ -18,6 +18,8 @@
<PackageReference Include="ShimSkiaSharp" GeneratePathProperty="true" PrivateAssets="all" />
<PackageReference Include="Fizzler" GeneratePathProperty="true" PrivateAssets="all" />
<PackageReference Include="ExCSS" GeneratePathProperty="true" PrivateAssets="all" />
<PackageReference Include="System.Drawing.Common" GeneratePathProperty="true" PrivateAssets="all" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why this is here? What is pulling it in or is it the netstandard TFM? Looking at the project.assets.josn all the System.Drawing is a dll in the ref of NETStandard.Library/2.0.3.

@rmarinho rmarinho merged commit 8e50312 into main May 28, 2024
49 checks passed
@rmarinho rmarinho deleted the update-drawing branch May 28, 2024 21:09
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions fixed-in-8.0.60 fixed-in-9.0.0-preview.5.24307.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants