-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revoke #19349. Fixes #20684 #22566
Revoke #19349. Fixes #20684 #22566
Conversation
This change comes from dotnet#19349, which simply and crudely piles up a large number of threads before loading the interface,Causing a significant decrease in performance. I don't have a better way, so I have to delete it
Hey there @BaY1251! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@BaY1251 do you still see your original issue on the latest nightly build of MAUI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen this type of loop happen a few times from this code, but, in my experience this usually happens because of bad code further up the chain. For example, this PR #22347 that will be part of SR6 fixes an issue where updates to Frame cause a bunch of ping ponging.
Plus, we also have an issue with rounding on android currently.
I'd be curious to investigate why the loop is happening before we just revert this code.
Closing this based on my findings here |
@PureWeen I don't think my PR is a good solution, fortunately you have found a better way |
@PureWeen
I am still searching for the root cause of the problem, it seems like it's not just a rounding problem. Code: log: |
I just need to delete this line of code and the world will be clean, but I believe the problem is not that simple. |
This change comes from #19349, which simply and crudely piles up a large number of threads before loading the interface,Causing a significant decrease in performance. I don't have a better way, so I have to delete it
Description of Change
Revoke src\Core\AndroidNative\maui\src\main\java\com\microsoft\maui\PlatformInterop.java changed in #19349
Issues Fixed
Fixes #20684