Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Crash during Scroll Animation while navigating away from Page - fix #22492

Merged
merged 3 commits into from
May 21, 2024
Merged

App Crash during Scroll Animation while navigating away from Page - fix #22492

merged 3 commits into from
May 21, 2024

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented May 17, 2024

Issues Fixed

Fixes #22443

@kubaflo kubaflo requested a review from a team as a code owner May 17, 2024 14:45
@kubaflo kubaflo requested review from Eilon and StephaneDelcroix May 17, 2024 14:45
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label May 17, 2024
@Eilon Eilon added the area-animation Animation, Transitions, Transforms label May 17, 2024
@kubaflo kubaflo force-pushed the fix-22443 branch 3 times, most recently from a474098 to b81de09 Compare May 17, 2024 18:19
@PureWeen
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen enabled auto-merge (squash) May 17, 2024 19:33
PureWeen
PureWeen requested changes May 18, 2024
View reviewed changes
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22443.cs
public override string Issue => "App Crash on Scroll Animation while navigating away from Page";

[Test]
public void NoExceptionShouldBeThrown()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is failing on catalyst

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-05-19 at 00 57 28 Should work now :)

auto-merge was automatically disabled May 18, 2024 17:52

Head branch was pushed to by a user without write access

@PureWeen
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen enabled auto-merge (squash) May 19, 2024 00:03
@PATRICKdallat
Copy link

Not a fix, just a cover up/workaround.
Please take a look at my comment in the bug ticket linked below.
#22443 (comment)

@jsuarezruiz jsuarezruiz self-requested a review May 21, 2024 13:45
@PureWeen
Copy link
Member

Failing test isn't related

@PureWeen PureWeen disabled auto-merge May 21, 2024 20:26
@PureWeen PureWeen merged commit 7ad1b69 into dotnet:main May 21, 2024
47 of 49 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen approved these changes

@Eilon Eilon Awaiting requested review from Eilon Eilon is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz

Assignees
No one assigned
Labels
area-animation Animation, Transitions, Transforms community ✨ Community Contribution fixed-in-8.0.60 fixed-in-9.0.0-preview.5.24307.10
Projects
None yet
Milestone
No milestone
6 participants
@kubaflo @PureWeen @PATRICKdallat @jsuarezruiz @Eilon @samhouts