[Windows] Avoid Carousel changes the current position when window is resized #22222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
jsuarezruiz
commented
May 6, 2024
| RowDefinitions="Auto, *, Auto"> | ||
| <Grid.Resources> | ||
|
|
||
| <DataTemplate x:Key="SampleItemTemplate"> |
PureWeen
reviewed
May 6, 2024
Foda
reviewed
May 6, 2024
| foreach (var item in ListViewBase.GetChildren<ItemContentControl>()) | ||
| { | ||
| item.ItemHeight = GetItemHeight(); | ||
| item.ItemWidth = GetItemWidth(); |
There was a problem hiding this comment.
It's beyond the scope of this PR, but I wonder why this logic isn't in the layout/measure pass. You'd think that item width + height is just calculated based on horizontal/vertical modes
Foda
requested changes
May 6, 2024
src/Controls/src/Core/Handlers/Items/CarouselViewHandler.Windows.cs
Outdated
Show resolved
Hide resolved
Foda
approved these changes
May 7, 2024
PureWeen
approved these changes
May 8, 2024
Eilon
added
t/perf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Avoid Carousel changes the current position when window is resized.
The problem is that, every time we change the size of the CarouselView (due to window size change, change in layouts, etc.) we are: reloading the ItemsSource, making adjustments to snap, making adjustments to center CurrentItem, etc. This has an important impact on performance in addition to being able (as you can see in the gif below) to change and set an incorrect CurrentItem.
Before
After
Issues Fixed
Fixes #22000
Fixes (partially) #18559
Related with #18014 (the issue contains more than one specific problem)