[net9.0] [testing] Enable Windows UITests back (#20727) and make sure Android works too #21636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like CG UI Tests still need some work? |
|
Yap |
|
Verified my change to extract the error message works on this one: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9368703&view=logs&j=9874f22e-7603-559c-9c5b-d2d8bb2e9740&t=ae92220e-833c-53d5-7f8d-25f60cff4b6c Now to fix the actual error |
rmarinho
approved these changes
Apr 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #21560
Revert of the revert.
This also adds additional functionality to the
FailRunOnOnlyInconclusiveTestsmethod which fails the pipeline when all tests are inconclusive. When this happens, this will now try to extract the error message from the test results file so you have to do less digging into the logs manually.The Android Control Gallery failures were not caused by this PR, but this PR does include a fix for that as well. That was also the reason the above error handling was implemented.
Fixes #21617