Make sure to await async test asserts (2) #20506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hey there @MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
MartyIX
commented
Feb 11, 2024
| @@ -63,9 +63,9 @@ public static async Task Run(Func<Task> asyncMethod) | |||
| // Invoke the function and alert the context when it's complete | |||
| var task = asyncMethod() ?? throw new InvalidOperationException("No task provided."); | |||
|
|
|||
| task.ContinueWith(async (t, o) => await context.Complete(), TaskScheduler.Default); | |||
| _ = task.ContinueWith(async (t, o) => await context.Complete(), TaskScheduler.Default); | |||
There was a problem hiding this comment.
Not sure about this one.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@jsuarezruiz What is the next step please? |
|
@mattleibow friendly ping |
MartyIX
force-pushed
the
dev/async-await-2
branch
2 times, most recently
from
9ae81ba to
ad7192d
Compare
|
@jsuarezruiz Ping please |
|
Azure Pipelines successfully started running 3 pipeline(s). |
MartyIX
force-pushed
the
dev/async-await-2
branch
from
ad7192d to
6c9f9c0
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
Mar 19, 2024
rmarinho
requested changes
Mar 20, 2024
There was a problem hiding this comment.
Seems we still have a couple more..
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\DeviceUnitTests.cs(92,67): error CS4014: Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call. [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\DeviceUnitTests.cs(131,69): error CS4014: Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call. [D:\a\_work\1\s\src\Controls\tests\Core.UnitTests\Controls.Core.UnitTests.csproj]
5928 Warning(s)
2 Error(s)
MartyIX
force-pushed
the
dev/async-await-2
branch
from
6c9f9c0 to
c7a94cf
Compare
I have modified it. |
|
@rmarinho Could you please re-run? |
|
@rmarinho Could you please re-run, or is there an issue? |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@rmarinho It looks like it succeeded..? |
rmarinho
approved these changes
Apr 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Await the async methods.
This PR just adds one commit to #19994 as CS4014 warnings are reported in my MSVS 17.9 P5 now:
cc @mattleibow