Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tizen] Update TizenUIExtensionsVersion #18442

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

JoonghyunCho
Copy link
Contributor

Description of Change

This PR updates the version of Tizen.UIExtensions to 0.9.1 to fix the security vulnerability caused by SkiaSharp.
The new version references SkiaSharp.Views version 2.88.6 which solves the issue.

Issues Fixed

Fixes CommunityToolkit/Maui#1424

This PR updates the version of `Tizen.UIExtensions` to 0.9.1 to fix the security vulnerability caused by SkiaSharp.
The new version references `SkiaSharp.Views` version 2.88.6 which solves the issue.
@JoonghyunCho JoonghyunCho requested a review from a team as a code owner October 31, 2023 06:08
@ghost ghost added the community ✨ Community Contribution label Oct 31, 2023
@ghost
Copy link

ghost commented Oct 31, 2023

Hey there @JoonghyunCho! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@JoonghyunCho
Copy link
Contributor Author

@rmarinho @mattleibow
Can you mirror https://www.nuget.org/packages/Tizen.UIExtensions.NUI/0.9.1 package to dotnet-public? repo? when you have a chance.

@rmarinho
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@JoonghyunCho
Copy link
Contributor Author

Still not found the latest(0.9.1) error on build step. Do I need to do something else to use new nuget?

D:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj : error NU1102: Unable to find package Tizen.UIExtensions.NUI with version (>= 0.9.1) [D:\a\_work\1\s\Microsoft.Maui.BuildTasks.slnf]
D:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj : error NU1102:   - Found 9 version(s) in dotnet-public [ Nearest version: 0.9.0 ] 

@mattleibow
Copy link
Member

I believe the mirror can't work as the nuget has invalid dependencies: https://www.nuget.org/packages/Tizen.UIExtensions.NUI

image

There is no MAUI RC 3 and nor does the Tizen.NET 10.0.0.17776 exist.

@JoonghyunCho
Copy link
Contributor Author

I believe the mirror can't work as the nuget has invalid dependencies: https://www.nuget.org/packages/Tizen.UIExtensions.NUI

image There is no MAUI RC 3 and nor does the Tizen.NET 10.0.0.17776 exist.

That's weird though, as its dependencies haven't changed. I will check the build again, thanks for pointing that out!

@rmarinho
Copy link
Member

rmarinho commented Nov 6, 2023

/azp run MAUI-UITests-public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis jfversluis merged commit 3503ec3 into dotnet:main Nov 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
@samhouts samhouts added the fixed-in-8.0.6 Look for this fix in 8.0.6 SR1! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community ✨ Community Contribution fixed-in-8.0.6 Look for this fix in 8.0.6 SR1!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Remove SkiaSharp.Views Dependency
5 participants