Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[net10.0] Enable warnings for CS9270 #27315

Closed
rmarinho opened this issue Jan 23, 2025 · 2 comments
Closed

[net10.0] Enable warnings for CS9270 #27315

rmarinho opened this issue Jan 23, 2025 · 2 comments
Labels
s/triaged Issue has been reviewed t/bug Something isn't working
Milestone
.NET 10 Planning

Comments

@rmarinho
Copy link
Member

rmarinho commented Jan 23, 2025 •
edited
Loading

Description

For getting the net10 to build with the latest bits we had to ignore error CS9270.

    <NoWarn>$(NoWarn);CS9270</NoWarn>

We should remove this as soon as we can on the net10 branch, the issues related with this on roslyn side
@rmarinho rmarinho added the t/bug Something isn't working label Jan 23, 2025
@rmarinho rmarinho added this to the .NET 10 Planning milestone Jan 23, 2025
@dotnet-policy-service dotnet-policy-service bot added the s/triaged Issue has been reviewed label Jan 23, 2025
@rmarinho rmarinho changed the title [net10] Enable warnings for CS9270 [net10.0] Enable warnings for CS9270 Jan 23, 2025
@jonathanpeppers
Copy link
Member

Should be fixed by:

But we will want to get this on the net10.0 branch and remove the $(NoWarn)=CS9270.

jonathanpeppers pushed a commit that referenced this issue Jan 28, 2025
@jkurdek @jonathanpeppers
[Binding SG] Removed deprecated InterceptsLocationAttribute (#27145)
96bb729 
Fixes: #27315

Backport of #27145 for .NET 10.

* [Binding SG] Updated InterceptsLocationAttribute

* Added System.Diagnostics.Conditional attribute
@jonathanpeppers jonathanpeppers mentioned this issue Jan 28, 2025
Merged
rmarinho pushed a commit that referenced this issue Jan 28, 2025
@jonathanpeppers @jkurdek
[net10.0] [Binding SG] Removed deprecated `InterceptsLocationAttribut…
27dabef 
…e` (#27408)

* [Binding SG] Removed deprecated `InterceptsLocationAttribute` (#27145)

Fixes: #27315

Backport of #27145 for .NET 10.

* [Binding SG] Updated InterceptsLocationAttribute

* Added System.Diagnostics.Conditional attribute

* Restore `#pragma warning disable RSEXPERIMENTAL002`

---------

Co-authored-by: Jeremi Kurdek <[email protected]>
@jfversluis
Copy link
Member

Indeed fixed by #27315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s/triaged Issue has been reviewed t/bug Something isn't working
Projects
None yet
Milestone
.NET 10 Planning
Development

No branches or pull requests
3 participants
@jonathanpeppers @jfversluis @rmarinho