Layout cycle crash on Windows with Button with image inside FlexLayout

[jeremy-visionaid]

Description

Reopen #21548

Steps to Reproduce

Reopen #21548

Link to public reproduction project repository

No response

Version with bug

8.0.20 SR4

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

8.0.7 SR2

Affected platforms

Windows

Affected platform versions

No response

Did you find any workaround?

No response

Relevant log output

No response

[jeremy-visionaid]

@Foda Please reopen #21548

[schlaman]

I have the same exception using FlexLayout and it works just fine with 8.0.14 but has the Layout Cycle crash with 8.0.20 (.NET Maui SR4).

This is a pretty severe bug. Will this be addressed quickly?

Thanks,
Craig

[jeremy-visionaid]

@schlaman Oh, that's interesting. The original bug pointed out that there were two manifestations of the problem. But it was closed permaturely since only one case (resizing) got fixed.

[Zhanglirong-Winnie]

Verified this issue with Visual Studio 17.10.0 Preview 4(8.0.20&8.0.14&8.0.10). Can repro on windows platform with sample project.
https://github.com/molesmoke/MauiTestApp/tree/flexlayout-cycle
8.0.10&8.0.14&8.0.20

8.0.7

[schlaman]

Awesome that you have it repro'd!

[jeremy-visionaid]

I also wrote a unit test to prevent regressions (currently with a Skip directive for Windows since it fails):
#21651

[schlaman]

Totally love the regression prevention!! I appreciate you being on this so quick. I'm about ready to release a major product I've worked on for the last year and really rely on .NET Maui being solid. I totally love what it has become :)

[PureWeen]

Can you test with the latest nightly?

https://github.com/dotnet/maui/wiki/Nightly-Builds

[mattleibow]

I wonder if this is fixed by #21737

[jeremy-visionaid]

@PureWeen @mattleibow I can do better than that, the referenced device test (#21651) is still failing on main (Although it's currently manifesting as a hang, you can still see the layout cycle messages in the debug output)

[BurkusCat]

This was something I was going to post myself a few weeks ago but it appeared to go away / not be in the release builds. Now I am getting it consistently and in the release builds in 8.0.20 SR4 (I think I got it in previous versions too).

I'm specifically getting the issue when the Buttons have a Margin applied to them. The crash goes away when there are no margins.

Here is a workaround I'm going with for the time being where I had some ContentViews to space things out. It will look bad in some scenarios but to be honest my FlexLayouts kind of looked bad already so it isn't too much worse for me 😂

<FlexLayout>
    <Button />
    <ContentView WidthRequest="5" />
    <Button />
    <ContentView WidthRequest="5" />
    <Button />
</FlexLayout>

@jeremy-visionaid in your original sample, I can workaround the issue by removing MinimumHeightRequest and MinimumWidthRequest from the global Button style. I'm guessing there will be quite a number of different triggers for the same exception.

[jeremy-visionaid]

@BurkusCat Looks like @Foda reworked the device test I wrote for it into #21733, so I'm hopeful this will all go away when it gets merged. But setting both MaximumWidthRequest and MaximumHeightRequest on the Buttons does prevent the layout cycle crash for me as a workaround.

[BurkusCat]

In MAUI 8.0.60 this appears to be fixed. I was able to remove the workaround and things look a lot nicer now 👍 Thank you