Remove Traversal project in favor of the solution file #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
requested review from
carlossanlop and
a team
and removed request for
carlossanlop
carlossanlop
reviewed
Nov 7, 2024
carlossanlop
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I double checked that the number of projects in the sln is identical with the projects on disk. The Traversal project doesn't provide any benefit but creates a second source of truth which we want to avoid.
Also classify test utility projects as such (IsTestUtilityProject is an Arcade SDK respected property).
Add the
UnsetIsPackableForNonSourceProjectsswitch that allows to unset the globally provided IsPackable property so that test projects don't get packaged up.