Skip to content

Commit

Permalink
Fix DotNetFinalVersionKind variable in yml (#170)
Browse files Browse the repository at this point in the history
Use a fixed parameter list containing the 3 possible options for the DotNetFinalVersionKind global property that generates the official packages.
  • Loading branch information
carlossanlop authored Nov 14, 2024
1 parent 5a136c3 commit 9007f15
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
1 change: 0 additions & 1 deletion eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<PropertyGroup>
<PreReleaseVersionLabel>rtm</PreReleaseVersionLabel>
<PreReleaseVersionIteration></PreReleaseVersionIteration>
<DotNetFinalVersionKind>release</DotNetFinalVersionKind>
<!-- Opt-out repo features -->
<UseVSTestRunner>true</UseVSTestRunner>
<UsingToolXliff>false</UsingToolXliff>
Expand Down
18 changes: 18 additions & 0 deletions eng/pipelines/maintenance-packages.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
parameters:
- name: DotNetFinalVersionKind
type: string
displayName: .NET Final Version Kind
values:
- none
- prerelease
- release
default: none

trigger:
batch: true
branches:
Expand All @@ -20,11 +30,18 @@ variables:
value: ''
- name: _BuildJobDisplayName
value: 'Build and Test'
- name: _DotNetFinalVersionKind
value: ''
- ${{ else }}:
- name: _AdditionalBuildArgs
value: '/p:Test=false'
- name: _BuildJobDisplayName
value: 'Build, Sign and Publish'
- name: _DotNetFinalVersionKind
${{ if eq(parameters.DotNetFinalVersionKind, 'none') }}:
value: ''
${{ else }}:
value: /p:DotNetFinalVersionKind=${{ parameters.DotNetFinalVersionKind }}

resources:
repositories:
Expand Down Expand Up @@ -91,6 +108,7 @@ extends:
-configuration Release
-prepareMachine
/p:Test=false
$(_DotNetFinalVersionKind)
$(_AdditionalBuildArgs)
$(_InternalBuildArgs)
displayName: $(_BuildJobDisplayName)
Expand Down

0 comments on commit 9007f15

Please sign in to comment.