Add AutoFill CredentialProvider NSExtensionPoint support #9030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New commits in xamarin/Xamarin.MacDev: * dotnet/macios-devtools@5e08f5f Add AutoFill CredentialProvider NSExtensionPoint support (dotnet#75) Diff: https://github.com/xamarin/Xamarin.MacDev/compare/a1bc6f39b3efe5d817c60d78eaff3f4c2de720ea..5e08f5f2fdf36110f563207f75f4685e582cc047
|
build |
spouliot
approved these changes
Jul 8, 2020
|
Great stuff - thanks for the contribution! |
chamons
approved these changes
Jul 8, 2020
mandel-macaque
approved these changes
Jul 8, 2020
|
Will backport this do d16-8 and will do an insertion with it so that is available ASAP. |
|
Build success |
whitneyschmidt
approved these changes
Jul 8, 2020
rolfbjarne
requested changes
Jul 8, 2020
|
Done and I think I've got it correct. Thanks for pointing that out! I'm (slowly) gathering a list of missing extension points and am planning on putting in pull requests for those as well, so this definitely helps me make sure they're complete. |
|
build |
|
Build failure Test results1 tests failed, 90 tests passed.Failed tests
|
emaf
approved these changes
Jul 13, 2020
This was referenced Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for AutoFill Credential Provider extensions to be built. Specifically, this resolves the issue with unrecognized extension point warnings being issued during the build process for Credential Providers. A related change to Xamarin.MacDev has already been merged.
For more information, see posted issue at: #9000