[Foundation] As a default, do not use the workaround in NSUrlSessionHandler for the threadpool. #8296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andler for thethreadpool. When an application was moved the the background, the thread pool from mono would be left in an unknonw state, making applications to stale (https://xamarin.github.io/bugzilla-archives/58/58633/bug.html#c7). This work was added in dotnet#5463 We now set the default behaviour to skip the workaround to see if the new provided mono works as expected. We do not fully remove the workaround because we need some real world testing. If the new ThreadPool from mono does not work as expected we do provide a property to re-add the workaround. The BypassBackgroundSessionCheck can be set to false to allow users get it back. The following is an example usage of the API: ```csharp // create your own handler instance rather than using the one provided by default. var handler = new NSUrlSessionHandler() { BypassBackgroundSessionCheck = false, // readd the hack }; var httpClient = new HttpClient (handler); // use the handler with the hack ``` This is a partial fix for dotnet#7080
mandel-macaque
requested review from
chamons,
rolfbjarne and
spouliot
as code owners
|
Adding do not merge, we have to wait for the d16-7 branch to be created. |
whitneyschmidt
approved these changes
Apr 6, 2020
|
@whitneyschmidt yes, we have Remove workaround for ThreadPool not working #7080 for that, this PR is not closing it :) |
|
Build success |
spouliot
approved these changes
Apr 6, 2020
mandel-macaque
changed the title
dalexsoto
approved these changes
Apr 6, 2020
|
d16-7 branched, landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an application was moved the the background, the thread pool from
mono would be left in an unknonw state, making applications to stale
(https://xamarin.github.io/bugzilla-archives/58/58633/bug.html#c7).
This work was added in #5463
We now set the default behaviour to skip the workaround to see if the
new provided mono works as expected. We do not fully remove the
workaround because we need some real world testing.
If the new ThreadPool from mono does not work as expected we do provide
a property to re-add the workaround. The BypassBackgroundSessionCheck
can be set to false to allow users get it back.
The following is an example usage of the API:
This is a partial fix for #7080