Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppKit] Add missing Accessibility protocols. #7105

Merged
merged 2 commits into from
Sep 26, 2019
Merged

[AppKit] Add missing Accessibility protocols. #7105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00c4170
[AppKit] Add missing Accessibility protocols.
mandel-macaque Sep 25, 2019
d3b0f20
Remove the new methods.
mandel-macaque Sep 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/appkit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25336,6 +25336,15 @@ interface NSAccessibilityRadioButton : NSAccessibilityButton {
NSNumber AccessibilityValue { get; }
}

[Mac (10,10)]
[Protocol]
interface NSAccessibilityCheckBox : NSAccessibilityButton
{
[Abstract]
[NullAllowed, Export ("accessibilityValue")]
NSNumber AccessibilityValue { get; }
}

[Mac (10,10)]
[Protocol]
interface NSAccessibilityStaticText : NSAccessibilityElementProtocol {
Expand Down Expand Up @@ -25489,10 +25498,12 @@ interface NSAccessibilityTable : NSAccessibilityGroup {
}

[Mac (10,10)]
[Protocol]
interface NSAccessibilityOutline : NSAccessibilityTable {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally that would break things... but since there's no [BaseType] I have the feeling that this was never generated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was never, correct.

}

[Mac (10,10)]
[Protocol]
interface NSAccessibilityList : NSAccessibilityTable {
}

Expand Down
6 changes: 1 addition & 5 deletions tests/xtro-sharpie/macOS-AppKit.ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,9 +617,6 @@
!missing-pinvoke! NSUpdateDynamicServices is not bound
!missing-pinvoke! NSWindowList is not bound
!missing-pinvoke! NSWindowListForContext is not bound
!missing-protocol! NSAccessibilityCheckBox not bound
!missing-protocol! NSAccessibilityList not bound
!missing-protocol! NSAccessibilityOutline not bound
!missing-protocol! NSAnimatablePropertyContainer not bound
!missing-protocol! NSChangeSpelling not bound
!missing-protocol! NSColorPickingCustom not bound
Expand All @@ -637,7 +634,6 @@
!missing-protocol-conformance! NSMenu should conform to NSAccessibilityElement
!missing-protocol-conformance! NSMenuItem should conform to NSAccessibilityElement
!missing-protocol-conformance! NSOpenGLContext should conform to NSLocking
!missing-protocol-conformance! NSOutlineView should conform to NSAccessibilityOutline
!missing-protocol-conformance! NSPageController should conform to NSAnimatablePropertyContainer
!missing-protocol-conformance! NSPathCell should conform to NSOpenSavePanelDelegate
!missing-protocol-conformance! NSSplitViewItem should conform to NSAnimatablePropertyContainer
Expand Down Expand Up @@ -1193,4 +1189,4 @@
!missing-selector! NSOpenGLView::wantsExtendedDynamicRangeOpenGLSurface not bound

!missing-release-attribute-on-return-value! AppKit.NSDictionaryControllerKeyValuePair AppKit.NSDictionaryController::get_NewObject()'s selector's ('newObject') Objective-C method family ('new') indicates that the native method returns a retained object, and as such a '[return: Release]' attribute is required.
!missing-release-attribute-on-return-value! Foundation.NSObject AppKit.NSObjectController::get_NewObject()'s selector's ('newObject') Objective-C method family ('new') indicates that the native method returns a retained object, and as such a '[return: Release]' attribute is required.
!missing-release-attribute-on-return-value! Foundation.NSObject AppKit.NSObjectController::get_NewObject()'s selector's ('newObject') Objective-C method family ('new') indicates that the native method returns a retained object, and as such a '[return: Release]' attribute is required.