Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xharness] Automatically pass -Os to the native linker when building watchOS extensions with the linker disabled. #4757

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

rolfbjarne
Copy link
Member

This works around #4689 for our own unit tests.

This also requires bumping the build timeout, because unfortunately using -Os
makes builds much, much slower.

…watchOS extensions with the linker disabled.

This works around dotnet#4689 for our own unit tests.

This also requires bumping the build timeout, because unfortunately using -Os
makes builds *much, much* slower.
Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (or another PR) should make sure only dont link (and not introspection) is being run without the linker enabled.

@monojenkins
Copy link
Collaborator

Build success
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
Test run succeeded

@rolfbjarne
Copy link
Member Author

This (or another PR) should make sure only dont link (and not introspection) is being run without the linker enabled.

https://github.com/xamarin/maccore/issues/1003

@rolfbjarne rolfbjarne merged commit bbb8a41 into dotnet:master Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants