Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIKit] Make UIApplication implement UIAccessibility. Fixes #21925. #21943

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

rolfbjarne
Copy link
Member

UIAccessibility is a category on NSObject, with a comment saying
"UIAccessibility is implemented on all standard UIKit views and controls".

We can't create a single binding that exposes UIAccessibility as that comment
states, and adding it to NSObject will create a lot of noise for all other
types.

So a long time ago we decided to only add UIAccessibility to a few UIKit types
(UIView, UIBarItem and UIImage), but it seems UIApplication should have it
too, so do that.

Fixes #21925.

UIAccessibility is a category on NSObject, with a comment saying
"UIAccessibility is implemented on all standard UIKit views and controls".

We can't create a single binding that exposes UIAccessibility as that comment
states, and adding it to NSObject will create a lot of noise for all other
types.

So a long time ago we decided to only add UIAccessibility to a few UIKit types
(UIView, UIBarItem and UIImage), but it seems UIApplication should have it
too, so do that.

Fixes #21925.
@rolfbjarne rolfbjarne requested a review from dalexsoto as a code owner January 10, 2025 18:13
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 561e4c84d9df4bac5da904382f06d1175b2a81ae [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 561e4c84d9df4bac5da904382f06d1175b2a81ae [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 561e4c84d9df4bac5da904382f06d1175b2a81ae [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )
  • iOS: vsdrops gist ( No breaking changes )
  • tvOS: vsdrops gist ( No breaking changes )
  • MacCatalyst: vsdrops gist ( No breaking changes )
  • macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 561e4c84d9df4bac5da904382f06d1175b2a81ae [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 561e4c84d9df4bac5da904382f06d1175b2a81ae [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 561e4c84d9df4bac5da904382f06d1175b2a81ae [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 561e4c84d9df4bac5da904382f06d1175b2a81ae [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

All Windows Integration Tests passed.

Pipeline on Agent
Hash: 561e4c84d9df4bac5da904382f06d1175b2a81ae [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 561e4c84d9df4bac5da904382f06d1175b2a81ae [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 111 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 561e4c84d9df4bac5da904382f06d1175b2a81ae [PR build]

@rolfbjarne rolfbjarne merged commit 76324ed into main Jan 13, 2025
48 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/uiapplication-uiaccessibility branch January 13, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UIApplication: AccessibilityLanguage API appears to be missing
4 participants