-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0.3xx] [tools] Don't link with NewsstandKit if we're using Xcode 15+. #18631
[release/7.0.3xx] [tools] Don't link with NewsstandKit if we're using Xcode 15+. #18631
Conversation
Apple completely removed the NewsstandKit framework in Xode 15. This effectively adds basic support for using Xcode 15 with .NET 7. While this technically won't be a supported scenario, we have tests that ensures .NET 7 apps can be built with .NET 8, and .NET 8 will ship with Xcode 15 support. This means that in order to make these tests work, we'll otherwise have to have Xcode 14.3 installed both locally and on bots (in addition to Xcode 15 of course), which is a rather big nightmare. It's much easier to must try to make Xcode 15 work with .NET 7.
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)
✅ API diff vs stable.NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 63 tests passed 🎉 Tests counts
Pipeline on Agent |
Apple completely removed the NewsstandKit framework in Xode 15.
This effectively adds basic support for using Xcode 15 with .NET 7.
While this technically won't be a supported scenario, we have tests that
ensures .NET 7 apps can be built with .NET 8, and .NET 8 will ship with Xcode
15 support. This means that in order to make these tests work, we'll otherwise
have to have Xcode 14.3 installed both locally and on bots (in addition to
Xcode 15 of course), which is a rather big nightmare.
It's much easier to must try to make Xcode 15 work with .NET 7.
Backport of #18626