[dotnet/msbuild] Copy binding resource packages to output directories together with CopyLocal assemblies. Fixes #13910. #17806

rolfbjarne · 2023-03-15T18:28:00Z

With a project structure like this:

Executable project references a library project.
The library project references a binding project (or assembly).

The binding project's assembly will be copied to the library project's output
directory during the build. Unless we also make sure any binding resource
packages are copied as well, the executable project won't find those, and the
final app won't contain any native bits from the binding project.

The solution is to add any binding resource packages to the list of files to
be copied to the library's output directory.

Fixes #13910.

…GetFileSystemEntries task. * Add support for multiple input paths. * Copy any metadata from input paths to the output paths. * Set the 'RecursiveDir' metadata on output paths, to match how globbing works in MSBuild. * Also set the 'OriginalItemSpec' metadata so that it's easier to compute derived paths afterwards. * Enable nullability.

… together with CopyLocal assemblies. Fixes dotnet#13910. With a project structure like this: * Executable project references a library project. * The library project references a binding project (or assembly). The binding project's assembly will be copied to the library project's output directory during the build. Unless we also make sure any binding resource packages are copied as well, the executable project won't find those, and the final app won't contain any native bits from the binding project. The solution is to add any binding resource packages to the list of files to be copied to the library's output directory. Fixes dotnet#13910.

github-actions · 2023-03-15T18:32:09Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

rolfbjarne · 2023-03-17T07:02:14Z

/azp run

azure-pipelines · 2023-03-17T07:02:36Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2023-03-17T08:35:18Z

🔥 Tests failed catastrophically on VSTS: simulator tests - bcl 🔥

Not enough free space in the host.

Pipeline on Agent
Merge cf6f005 into f37c86b

vs-mobiletools-engineering-service2 · 2023-03-17T08:48:54Z

🔥 Tests failed catastrophically on VSTS: simulator tests - interdependent-binding-projects 🔥

Not enough free space in the host.

Pipeline on Agent
Merge cf6f005 into f37c86b

vs-mobiletools-engineering-service2 · 2023-03-17T08:51:44Z

🔥 Tests failed catastrophically on VSTS: simulator tests - xcframework 🔥

Not enough free space in the host.

Pipeline on Agent
Merge cf6f005 into f37c86b

dotnet/targets/Xamarin.Shared.Sdk.targets

vs-mobiletools-engineering-service2 · 2023-03-21T19:00:41Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: de081a22c90b5fe5b028e722646779db0bd5339a [PR build]

vs-mobiletools-engineering-service2 · 2023-03-21T19:21:30Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: de081a22c90b5fe5b028e722646779db0bd5339a [PR build]

vs-mobiletools-engineering-service2 · 2023-03-21T19:24:56Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: de081a22c90b5fe5b028e722646779db0bd5339a [PR build]

vs-mobiletools-engineering-service2 · 2023-03-21T19:26:06Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: de081a22c90b5fe5b028e722646779db0bd5339a [PR build]

vs-mobiletools-engineering-service2 · 2023-03-22T09:30:06Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 224 tests passed.

Failures

❌ bcl tests

1 tests failed, 68 tests passed.

mscorlib Part 3/tvOS - simulator/Debug: Crashed

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: de081a22c90b5fe5b028e722646779db0bd5339a [PR build]

rolfbjarne · 2023-03-22T09:48:40Z

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2450).

rolfbjarne added 2 commits March 15, 2023 19:22

rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label Mar 15, 2023

Auto-format source code

3f69c42

This comment has been minimized.

Sign in to view

Copy to output directory, but don't publish.

cf6f005

This comment has been minimized.

Sign in to view

Merge branch 'main' into issue-13910

3c29750

rolfbjarne marked this pull request as ready for review March 21, 2023 07:13

rolfbjarne requested review from emaf and mauroa as code owners March 21, 2023 07:13

This comment has been minimized.

Sign in to view

emaf reviewed Mar 21, 2023

View reviewed changes

dotnet/targets/Xamarin.Shared.Sdk.targets Show resolved Hide resolved

emaf approved these changes Mar 21, 2023

View reviewed changes

rolfbjarne added 2 commits March 21, 2023 18:34

Merge remote-tracking branch 'origin/main' into issue-13910

3e678e4

Correct comment.

de081a2

rolfbjarne merged commit 7ea0044 into dotnet:main Mar 22, 2023

rolfbjarne deleted the issue-13910 branch March 22, 2023 09:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dotnet/msbuild] Copy binding resource packages to output directories together with CopyLocal assemblies. Fixes #13910. #17806

[dotnet/msbuild] Copy binding resource packages to output directories together with CopyLocal assemblies. Fixes #13910. #17806

rolfbjarne commented Mar 15, 2023

github-actions bot commented Mar 15, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Mar 17, 2023

azure-pipelines bot commented Mar 17, 2023

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 17, 2023

vs-mobiletools-engineering-service2 commented Mar 17, 2023

vs-mobiletools-engineering-service2 commented Mar 17, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 21, 2023

vs-mobiletools-engineering-service2 commented Mar 21, 2023

vs-mobiletools-engineering-service2 commented Mar 21, 2023

vs-mobiletools-engineering-service2 commented Mar 21, 2023

vs-mobiletools-engineering-service2 commented Mar 22, 2023

rolfbjarne commented Mar 22, 2023

[dotnet/msbuild] Copy binding resource packages to output directories together with CopyLocal assemblies. Fixes #13910. #17806

[dotnet/msbuild] Copy binding resource packages to output directories together with CopyLocal assemblies. Fixes #13910. #17806

Conversation

rolfbjarne commented Mar 15, 2023

github-actions bot commented Mar 15, 2023

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Mar 17, 2023

azure-pipelines bot commented Mar 17, 2023

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 17, 2023

🔥 Tests failed catastrophically on VSTS: simulator tests - bcl 🔥

vs-mobiletools-engineering-service2 commented Mar 17, 2023

🔥 Tests failed catastrophically on VSTS: simulator tests - interdependent-binding-projects 🔥

vs-mobiletools-engineering-service2 commented Mar 17, 2023

🔥 Tests failed catastrophically on VSTS: simulator tests - xcframework 🔥

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 21, 2023

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Mar 21, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

✅ Generator diff

vs-mobiletools-engineering-service2 commented Mar 21, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

vs-mobiletools-engineering-service2 commented Mar 21, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Mar 22, 2023

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ bcl tests

Successes

rolfbjarne commented Mar 22, 2023