-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Rework how we handle manifest version bands. #17670
Conversation
* Use a separate variable for Mono's and Emscripten's manifest version band, so that they can diverge (this is a decision from the corresponding teams, we don't control it). * Have a separate variable for our own manifest version band, so that it's easier to hard code it if we want to. * Rename a few variables to make them clearer. * Remove hardcoded rc.2 logic, we're not using any rc.2 versions right now, so that's dead code. * A few other minor changes.
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Ventura (13.0) failed ❌Failed tests are:
Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 225 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. [attempt 2] Html Report (VSDrops) Download Pipeline on Agent |
so that they can diverge (this is a decision from the corresponding teams,
we don't control it).
easier to hard code it if we want to.
that's dead code.