-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[src] Create XML documentation when building our platform assemblies for .NET. Fixes #17395. #17476
Conversation
…for .NET. Fixes dotnet#17395. Fixes dotnet#17395.
Unfortunately XML comments can't be conditionally compiled (dotnet/csharplang#295), so we have to duplicate a lot of content that is just slightly different.
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 225 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
#if NET | ||
/// <summary>Transform a Vector by the given Matrix</summary> | ||
/// <param name="vec">The column vector to transform</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the pr fault, but funny indentation.
#if NET | ||
/// <summary>Transform a Vector by the given Matrix.</summary> | ||
/// <param name="vec">The column vector to transform</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
Also fix XML comments to be valid and not produce compiler warnings.
Unfortunately XML comments can't be conditionally compiled
(dotnet/csharplang#295), so we have to
duplicate a lot of content that is just slightly different.
Fixes #17395.