[dotnet/tools] Don't disable compact unwind info. Fixes #16546. #16623
Conversation
Don't disable compact unwind info in the native linker, it may break C++ exception handling. We originally disabled compact unwind info to fix a warning from the native linker, this will have to be solved another way (in any case extra build warnings is preferrable compared to an app crashing at runtime due to broken C++ exception handling). This partially reverts c05e774. Fixes dotnet#16546.
|
/sudo backport xcode14.1 |
|
Backport Job to branch xcode14.1 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6929742 for more details. |
❗ API diff for current PR / commit (Breaking changes)Legacy Xamarin (No breaking changes)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:).NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)✅ Generator diffGenerator diff is empty Pipeline on Agent |
📚 [PR Build] Artifacts 📚Artifacts were not provided. Pipeline on Agent XAMBOT-1175.Monterey' |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 223 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
…16546. (#16624) Don't disable compact unwind info in the native linker, it may break C++ exception handling. We originally disabled compact unwind info to fix a warning from the native linker, this will have to be solved another way (in any case extra build warnings is preferable compared to an app crashing at runtime due to broken C++ exception handling). This partially reverts c05e774. Fixes #16546. Backport of #16623 Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
|
Just for the record, adding this to the project file should work around the project for .NET projects (but not legacy Xamarin projects like this issue was originally reported for): <Target Name="_FixLinkNativeExecutableInputs" AfterTargets="_ComputeLinkNativeExecutableInputs">
<ItemGroup>
<_MainLinkerFlags Remove="-Wl,-no_compact_unwind" />
<_MainLinkerFlags Remove="-Wl,-keep_dwarf_unwind" />
</ItemGroup>
</Target> |
…ixes #16546. (#16769) Don't disable compact unwind info in the native linker, it may break C++ exception handling. We originally disabled compact unwind info to fix a warning from the native linker, this will have to be solved another way (in any case extra build warnings is preferrable compared to an app crashing at runtime due to broken C++ exception handling). This partially reverts c05e774. Fixes #16546. Backport of #16623 Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
…nd info. Fixes #16546. (#16770) Don't disable compact unwind info in the native linker, it may break C++ exception handling. We originally disabled compact unwind info to fix a warning from the native linker, this will have to be solved another way (in any case extra build warnings is preferrable compared to an app crashing at runtime due to broken C++ exception handling). This partially reverts c05e774. Fixes #16546. Backport of #16623 Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
Don't disable compact unwind info in the native linker, it may break C++
exception handling.
We originally disabled compact unwind info to fix a warning from the native
linker, this will have to be solved another way (in any case extra build
warnings is preferrable compared to an app crashing at runtime due to broken
C++ exception handling).
This partially reverts c05e774.
Fixes #16546.