Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[monotouch-test] Update QuantityTypeIdentifier.EnumValues_22351 after recent API additions. Fixes #16443. #16498

Merged
merged 4 commits into from
Oct 28, 2022

Conversation

rolfbjarne
Copy link
Member

Fixes #16443.

@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Oct 27, 2022
@tj-devel709
Copy link
Member

I don't think this will address the second half of the failures though

EnumValues_22351: No failures
Expected: <empty>
But was: < "InfrequentMenstrualCycles could not be created: System.NullReferenceException: Object reference not set to an instance of an object
at MonoTouchFixtures.HealthKit.CategoryTypeIdentifier.EnumValues_22351() in /Users/builder/azdo/_work/1/s/xamarin-macios/tests/monotouch-test/HealthKit/CategoryTypeIdentifierTest.cs:line 133", "IrregularMenstrualCycles could not be created: System.NullReferenceException: Object reference not set to an instance of an object
at MonoTouchFixtures.HealthKit.CategoryTypeIdentifier.EnumValues_22351() in /Users/builder/azdo/_work/1/s/xamarin-macios/tests/monotouch-test/HealthKit/CategoryTypeIdentifierTest.cs:line 133", "PersistentIntermenstrualBleeding could not be created: System.NullReferenceException: Object reference not set to an instance of an object
at MonoTouchFixtures.HealthKit.CategoryTypeIdentifier.EnumValues_22351() in /Users/builder/azdo/_work/1/s/xamarin-macios/tests/monotouch-test/HealthKit/CategoryTypeIdentifierTest.cs:line 133", "ProlongedMenstrualPeriods could not be created: System.NullReferenceException: Object reference not set to an instance of an object
at MonoTouchFixtures.HealthKit.CategoryTypeIdentifier.EnumValues_22351() in /Users/builder/azdo/_work/1/s/xamarin-macios/tests/monotouch-test/HealthKit/CategoryTypeIdentifierTest.cs:line 133" >

EnumValues_22351: No failures
Expected: <empty>
But was: < "AppleSleepingWristTemperature could not be created: System.NullReferenceException: Object reference not set to an instance of an object
at MonoTouchFixtures.HealthKit.QuantityTypeIdentifier.EnumValues_22351() in /Users/builder/azdo/_work/1/s/xamarin-macios/tests/monotouch-test/HealthKit/QuantityTypeIdentifierTest.cs:line 114", "UnderwaterDepth could not be created: System.NullReferenceException: Object reference not set to an instance of an object
at MonoTouchFixtures.HealthKit.QuantityTypeIdentifier.EnumValues_22351() in /Users/builder/azdo/_work/1/s/xamarin-macios/tests/monotouch-test/HealthKit/QuantityTypeIdentifierTest.cs:line 114", "WaterTemperature could not be created: System.NullReferenceException: Object reference not set to an instance of an object
at MonoTouchFixtures.HealthKit.QuantityTypeIdentifier.EnumValues_22351() in /Users/builder/azdo/_work/1/s/xamarin-macios/tests/monotouch-test/HealthKit/QuantityTypeIdentifierTest.cs:line 114" >

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rolfbjarne I think this should be good enough

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Also bumping check to 14.1 to ease testing on macOS 13 since these are already present in iOS 16.
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 82d434a90580932c59386b0c9bf1c7db5d447d18 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1165.Monterey'
Hash: 82d434a90580932c59386b0c9bf1c7db5d447d18 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: 82d434a90580932c59386b0c9bf1c7db5d447d18 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne rolfbjarne merged commit f4bfa0d into dotnet:xcode14.1 Oct 28, 2022
@rolfbjarne rolfbjarne deleted the issue-16443 branch October 28, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants