Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0.4xx] [debugger] Work around a debugger issue when using the interpreter. #15510

Merged
merged 1 commit into from
Jul 18, 2022
Merged

[release/6.0.4xx] [debugger] Work around a debugger issue when using the interpreter. #15510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions runtime/monovm-bridge.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@
void
xamarin_bridge_initialize ()
{
#if DOTNET
bool use_mono_workaround = xamarin_init_mono_debug && getenv ("XAMARIN_SKIP_INTERPRETER_DEBUGGING_WORKAROUND") == 0;
#else
bool use_mono_workaround = false;
#endif

if (xamarin_register_modules != NULL)
xamarin_register_modules ();
DEBUG_LAUNCH_TIME_PRINT ("\tAOT register time");
Expand All @@ -69,9 +75,9 @@
DEBUG_LAUNCH_TIME_PRINT ("\tDebug init time");
#endif

if (xamarin_init_mono_debug)
if (xamarin_init_mono_debug && !use_mono_workaround)
mono_debug_init (MONO_DEBUG_FORMAT_MONO);

mono_install_assembly_preload_hook (xamarin_assembly_preload_hook, NULL);
mono_install_load_aot_data_hook (xamarin_load_aot_data, xamarin_free_aot_data, NULL);

Expand All @@ -85,7 +91,32 @@
mono_install_unhandled_exception_hook (xamarin_unhandled_exception_handler, NULL);
mono_install_ftnptr_eh_callback (xamarin_ftnptr_exception_handler);

mono_jit_init_version ("MonoTouch", "mobile");
const char *argc[] = {
"",
"--interp=-all",
"",
NULL,
};

if (use_mono_workaround) {
// This is a workaround for a runtime bug that prevents debugging from working properly.
// We call mono_main to disable interpreter optimizations when debugging, because
// mono's own interpreter initialization doesn't take into account that the debugger
// might be attached, and the subsequent optimizations can break the debugger.
// The stdout dance is to hide mono's "helpful" output telling us the command line
// arguments are incorrect (which they would be normally, but we're abusing mono_main
// to get the side effects).
fflush (stdout);
int originalStdout = dup (STDOUT_FILENO);
int devnull = open ("/dev/null", O_RDWR);
dup2 (devnull, STDOUT_FILENO);
mono_main (2, (char**)argc);
fflush (stdout);
dup2 (originalStdout, STDOUT_FILENO);
} else {
mono_jit_init_version ("MonoTouch", "mobile");
}

/*
As part of mono initialization a preload hook is added that overrides ours, so we need to re-instate it here.
This is wasteful, but there's no way to manipulate the preload hook list except by adding to it.
Expand Down