[dotnet][generator] Fix creating 3rd party bindings #11522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally the generator uses `AvailabilityBaseAttribute` to make its decisions. For `dotnet` we generated the newer `[SupportedOSPlatform]` and `[UnsupportedOSPlatform]`. A 3rd-party (dotnet) binding might refer to members decorated with the newer attributes and fail the build with an error [1]. Avoiding the error is easy (first block of the diff) but it does not make the _right_ decisions (e.g. if a member is unavailable for the platform) when generating the code. To fix this we need to be able to convert the new attributes into the well know `AvailabilityBaseAttribute` subclasses. We have not spotted such cases yet because * the bindings pass our tests (good but extra code would not fail) * API diff across legacy and dotnet is not yet done [2] [1] dotnet#11497 [2] dotnet#10210
tj-devel709
approved these changes
May 12, 2021
dalexsoto
approved these changes
May 12, 2021
| default: | ||
| return Enumerable.Empty<System.Attribute> (); | ||
| } | ||
| } | ||
|
|
||
| #if NET | ||
| static (PlatformName, Version) ParseOSPlatformAttribute (string arg) |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) 🎉 All 84 tests passed 🎉Pipeline on Agent XAMBOT-1099.BigSur |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally the generator uses
AvailabilityBaseAttributeto make itsdecisions. For
dotnetwe generated the newer[SupportedOSPlatform]and
[UnsupportedOSPlatform].A 3rd-party (dotnet) binding might refer to members decorated with the
newer attributes and fail the build with an error [1]. Avoiding the error
is easy (first block of the diff) but it does not make the right
decisions (e.g. if a member is unavailable for the platform) when
generating the code.
To fix this we need to be able to convert the new attributes into the
well know
AvailabilityBaseAttributesubclasses. We have not spottedsuch cases yet because
[1] #11497
[2] #10210