Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet] Enable more trimming switches #11295

Merged
merged 1 commit into from
Apr 23, 2021
Merged

[dotnet] Enable more trimming switches #11295

merged 1 commit into from
Apr 23, 2021

Conversation

spouliot
Copy link
Contributor

@spouliot spouliot added the not-notes-worthy Ignore for release notes label Apr 22, 2021
dalexsoto
dalexsoto approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sebastien.Sort ✅

@spouliot
Copy link
Contributor Author

@dalexsoto yeah I ❤️ sorted keys 😄 but in this case there was a typo too: HttpNativeHandler != UseNativeHttpHandler

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

Test results

2 tests failed, 102 tests passed.

Failed tests

  • link all/iOS Unified 64-bits - simulator/Debug: Failed
  • link all/tvOS - simulator/Debug: Failed

Pipeline on Agent XAMBOT-1109'
Merge 06148b3 into 0924ce5

@spouliot
Copy link
Contributor Author 

TrustUsingOldPolicy: System.Net.WebException : Error: TrustFailure (Authentication failed, see inner exception.)
----> System.Security.Authentication.AuthenticationException : Authentication failed, see inner exception.
----> NUnit.Framework.AssertionException : Unknown Certificate Problem
Expected: 0
But was: -2146762485
1) Unknown Certificate Problem
Expected: 0
But was: -2146762485

known, likely network related, issue -> https://github.com/xamarin/maccore/issues/2211

@spouliot spouliot merged commit 095b7e1 into dotnet:main Apr 23, 2021
@spouliot spouliot deleted the enable-moar-switches branch April 23, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spouliot @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne @mandel-macaque