Bump maccore to fix mlaunch NRE when starting Simulator bundles #11165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spouliot
approved these changes
Apr 8, 2021
|
/azp run |
mandel-macaque
approved these changes
Apr 8, 2021
|
Azure Pipelines successfully started running 1 pipeline(s). |
dalexsoto
approved these changes
Apr 8, 2021
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffTest results15 tests failed, 79 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.Catalina' |
|
@premun looks like we have failures and the are related with the sim. |
premun
force-pushed
the
prvysoky/maccore-bump
branch
from
cd6b53e to
fde6d95
Compare
|
@mandel-macaque I might have actually created the commit on an old commit from main. I checked the logs and it doesn't seem related. Also the command that I was fixing is not used in this repository but hopefully I didn't introduce some side effect. I rebased so let's try again. |
|
@premun this is because of the P4 bump that was auto merged, even if not tested (and incorrect). You can just merge |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 11165 in repo xamarin/xamarin-macios |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffTest results2 tests failed, 96 tests passed.Failed tests
Pipeline on Agent XAMBOT-1110 |
|
Ah! much better! |
dalexsoto
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New commits in xamarin/maccore:
--launchsimbundleidaction ([coreimage] CIImageAccumulator API fixes. Fix #58349 #2412)Diff: https://github.com/xamarin/maccore/compare/b9aaee72545d046614dd5fa77e947a9372381013..c89fd6a694110794099592488bf7f15915d99e74