Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[messages] Update to iOS 10.2 beta 1 #1112

Merged
merged 1 commit into from
Nov 7, 2016
Merged

[messages] Update to iOS 10.2 beta 1 #1112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/messages.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ interface MSMessageTemplateLayout

[iOS (10,0)]
[BaseType (typeof(NSObject))]
interface MSSession {}
interface MSSession : NSSecureCoding {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try running this on older sims - it will likely need an adjustment to the intro tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spouliot I tried running the intro tests on an iOS 10.0 sim and they all passed just fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because the type is already part of the exception list, i.e. case "MSSession":


[iOS (10,0)]
[BaseType (typeof(NSObject))]
Expand Down