[dotnet] Fix device builds #11036
Merged
[dotnet] Fix device builds #11036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With P3 addition on ICU we must now link the native executable as C++. Remove an old workaround, in many tests, referencing old (5.0/previews) packages that caused native link time failures. ref: dotnet/linker#1139
|
This fix the build itself. There's a crash happening at startup -> dotnet/runtime#50290 (comment) |
dalexsoto
approved these changes
Mar 30, 2021
|
I 👀 U |
mandel-macaque
approved these changes
Mar 30, 2021
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffTest results4 tests failed, 178 tests passed.Failed tests
Pipeline on Agent XAMBOT-1103 |
filipnavara
approved these changes
Mar 31, 2021
emaf
approved these changes
Mar 31, 2021
tj-devel709
pushed a commit
that referenced
this pull request
Apr 7, 2021
With P3 addition on ICU we must now link the native executable as C++. Remove an old workaround, in many tests, referencing old (5.0/previews) packages that caused native link time failures. ref: dotnet/linker#1139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With P3 addition on ICU we must now link the native executable as C++.
Remove an old workaround, in many tests, referencing old (5.0/previews)
packages that caused native link time failures.
ref: dotnet/linker#1139