[apidiff] Compare Xamarin.iOS between iOS and MacCatalyst #10924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xamarin.MacCatalyst ships a `Xamarin.iOS.dll` assembly that contains forwarders (to `Xamarin.MacCatalyst.dll`) and stubs that throws `PlatformNotSupportedException`. This is used to help code compatibility between both platforms - but that requires exposing an identical surface and the best way to ensure this is to compare (and report) them using `apidiff`
dalexsoto
approved these changes
Mar 19, 2021
|
Needs a small change to add the urls, adding it |
|
@mandel-macaque of course, yaml == You Ask ManueL |
spouliot
commented
Mar 19, 2021
| @@ -70,6 +71,7 @@ steps: | |||
| "iOS" = $apiDiffRoot + "ios-api-diff.html"; | |||
| "macOS" = $apiDiffRoot + "mac-api-diff.html"; | |||
| "macCat" = $apiDiffRoot + "maccat-api-diff.html"; | |||
| "macCatiOS" = $apiDiffRoot + "maccat-to-ios-diff.html"; | |||
There was a problem hiding this comment.
there's no .html just .md for this one
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diff
Test results1 tests failed, 181 tests passed.Failed tests
Pipeline on Agent XAMBOT-1095' |
✅ Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diff🎉 All 182 tests passed 🎉Pipeline on Agent XAMBOT-1094' |
rolfbjarne
approved these changes
Mar 22, 2021
5 tasks
|
last commit is not quite ok (single link for macCat* diffs) c.c. @mandel-macaque |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xamarin.MacCatalyst ships a
Xamarin.iOS.dllassembly that containsforwarders (to
Xamarin.MacCatalyst.dll) and stubs that throwsPlatformNotSupportedException.This is used to help code compatibility between both platforms - but
that requires exposing an identical surface and the best way to ensure
this is to compare (and report) them using
apidiffexample: https://gist.github.com/spouliot/984c92ce97d2b294088606f0bf697ef8
part of #10210