Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MKMapRect.World #14787

Closed
yaliashkevich opened this issue Apr 20, 2022 · 1 comment · Fixed by #17522
Closed

MKMapRect.World #14787

yaliashkevich opened this issue Apr 20, 2022 · 1 comment · Fixed by #17522
Assignees
@haritha-mohan
Labels
breaking-change If an issue or a pull request represents a breaking change enhancement The issue or pull request is an enhancement
Milestone
XAMCORE_5_0

Comments

@yaliashkevich
Copy link
Contributor

Is it any reason to have MKMapRect.World being instance instead of static property?
https://github.com/xamarin/xamarin-macios/blob/7d229665c88b692bcd28bbf3992b498820b0ccf8/src/MapKit/MapKit.cs#L337-L341
@chamons
Copy link
Contributor

chamons commented Apr 21, 2022

Likely no, but unforteuntely changing it is an API breaking change.

@chamons chamons added this to the Future milestone Apr 21, 2022
@chamons chamons added enhancement The issue or pull request is an enhancement breaking-change If an issue or a pull request represents a breaking change labels Apr 21, 2022
@rolfbjarne rolfbjarne modified the milestones: Future, XAMCORE_5_0 Apr 21, 2022
haritha-mohan added a commit to haritha-mohan/xamarin-macios that referenced this issue Feb 12, 2023
@haritha-mohan
[MapKit] Make MKMapRect.World static
10c1044 
Fixes dotnet#14787
@haritha-mohan haritha-mohan mentioned this issue Feb 13, 2023
Merged
haritha-mohan added a commit that referenced this issue Feb 14, 2023
@haritha-mohan
[MapKit] Make MKMapRect.World static (#17522)
375e8c6 
Fixes #14787
@ghost ghost locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@haritha-mohan haritha-mohan

Labels
breaking-change If an issue or a pull request represents a breaking change enhancement The issue or pull request is an enhancement
Projects
None yet
Milestone
XAMCORE_5_0
Development

Successfully merging a pull request may close this issue.

[MapKit] Make MKMapRect.World static haritha-mohan/xamarin-macios
4 participants
@rolfbjarne @yaliashkevich @chamons @haritha-mohan