Skip to content

Commit

Permalink
[tests][linkall] Add a check that the Makefile produced version numbe…
Browse files Browse the repository at this point in the history
…r is 'legit'. Fixes #4859 (#5005)

History: a marge conflict caused a version string to become "12.3." and
this was found in the API diff much later.

reference: #4859
  • Loading branch information
spouliot authored Oct 18, 2018
1 parent dca1f47 commit 5ad55d6
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions tests/linker/CommonLinkAllTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,13 @@ public void TypeConverter_Custom ()
string name = (typeof (TypeDescriptorTest).GetCustomAttributes (false) [0] as TypeConverterAttribute).ConverterTypeName;
Assert.That (name, Is.EqualTo ("LinkAll.CustomConverter, link all, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null"), "ConverterTypeName");
}

[Test]
public void ConstantsVersion_4859 ()
{
// Check that the Makefile generated a valid version number, e.g. "12.3." was not
// reference: https://github.com/xamarin/xamarin-macios/issues/4859
Assert.True (Version.TryParse (ObjCRuntime.Constants.Version, out var _), "Version");
}
}
}

1 comment on commit 5ad55d6

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins job (on internal Jenkins) succeeded

Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
Generator Diff (no change)
Test run succeeded

Please sign in to comment.