Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[d16-6][corefoundation] Fix TypeInitializationException in OSLog (#7962…
…) (#7977) `Default` property was using a nil-handle which is incorrect since * we don't allow that (this is generally a bad sign) * it does not map to `OS_LOG_DEFAULT` Since `Default` was assigned in the type (static) constructor then the whole type became unusable :( Header `log.h` shows that the right definition requires us to load a field and use it. ``` define OS_LOG_DEFAULT OS_OBJECT_GLOBAL_OBJECT(os_log_t, _os_log_default) ``` While `NULL` can actually be used for disabled (not exposed) by this contradicting (nullability-wise) macro ``` define OS_LOG_DISABLED ((os_log_t _Nonnull)NULL) ``` Also adds unit tests. A more general tests for `.cctor` will be added to introspection tests in a separate PR. Fixes #7959
- Loading branch information
514991e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚧 Experimental DDFun pipeline
🔥 Device tests completed (Failed) on iOS-DDFun on Azure DevOps(iOS-DDFun) 🔥
Test results
8 tests failed, 142 tests passed.
Failed tests
514991e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Device tests completed (Failed) on iOS on Azure DevOps(iOS): Html Report 🔥
Test results
8 tests failed, 142 tests passed.
Failed tests
514991e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Device tests completed (Failed) on TvOS on Azure DevOps(TvOS): Html Report 🔥
Test results
1 tests failed, 149 tests passed.
Failed tests
514991e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Build was (probably) aborted
🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥
✅ Build succeeded
✅ Packages:
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥
Test results
4 tests failed, 179 tests passed.
Failed tests
514991e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Build was (probably) aborted
🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Checkout' 🔥 : org.jenkinsci.plugins.workflow.steps.FlowInterruptedException
514991e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Jenkins job (on internal Jenkins) succeeded
✅ Build succeeded
✅ Packages:
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
✅ Test run succeeded
514991e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚧 Experimental DDFun pipeline
🔥 Device tests completed (Failed) on iOS-DDFun on Azure DevOps(iOS-DDFun) 🔥
Test results
14 tests failed, 136 tests passed.
Failed tests
514991e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Device tests passed on iOS on Azure DevOps(iOS): Html Report ✅
🎉 All 150 tests passed 🎉
514991e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Device tests completed (Failed) on iOS32b on Azure DevOps(iOS32b): Html Report 🔥
Test results
20 tests failed, 141 tests passed.
Failed tests
514991e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Device tests completed (Failed) on TvOS on Azure DevOps(TvOS): Html Report 🔥
Test results
14 tests failed, 136 tests passed.
Failed tests
514991e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Device tests completed (Failed) on iOS32b on Azure DevOps(iOS32b): Html Report 🔥
Test results
# Test run in progress: Running: 1, RunQueued: 26, Succeeded: 111, Failed: 14, Ignored: 1100, Crashed: 1, TimedOut: 5, BuildFailure: 3
Failed tests