Skip to content

Commit

Permalink
[sensorkit] Add nullability to (generated and manual) bindings (#14881)
Browse files Browse the repository at this point in the history
Co-authored-by: TJ Lambert <[email protected]>
  • Loading branch information
tj-devel709 and TJ Lambert authored May 4, 2022
1 parent d25d6be commit 4f1ad9c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/SensorKit/SRSensor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public partial class SRSensorExtensions {
public static SRSensor GetSensorForDeletionRecords (this SRSensor self)
{
var constant = self.GetConstant ();
if (constant == null)
if (constant is null)
return SRSensor.Invalid;
return GetValue (constant._GetSensorForDeletionRecordsFromSensor ());
}
Expand Down

5 comments on commit 4f1ad9c

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests on macOS Mac Catalina (10.15) failed ❌

Failed tests are:

  • introspection

Pipeline on Agent
Hash: 4f1ad9cb18f9ea081eaf2397d6c9e8e7184aa546

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 [CI Build] API Diff 📋

API Current PR diff

✅ API Diff (from PR only) (no change)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

Generator Diff (no change)

Pipeline on Agent XAMMINI-052.Monterey'
Hash: 4f1ad9cb18f9ea081eaf2397d6c9e8e7184aa546

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 4f1ad9cb18f9ea081eaf2397d6c9e8e7184aa546

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📚 [CI Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMMINI-061.Monterey
Hash: 4f1ad9cb18f9ea081eaf2397d6c9e8e7184aa546

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌

Tests failed on VSTS: simulator tests iOS.

Test results

2 tests failed, 232 tests passed.

Failed tests

  • introspection/iOS Unified 64-bits - simulator/Debug (iOS 12.4) [dotnet]: Failed
  • introspection/tvOS - simulator/Debug (tvOS 12.4) [dotnet]: Failed

Pipeline on Agent XAMBOT-1098.Monterey'
[sensorkit] Add nullability to (generated and manual) bindings (#14881)

Please sign in to comment.