Skip to content

Commit

Permalink
[AppKit] Add missing Accessibility protocols. (#7105)
Browse files Browse the repository at this point in the history
  • Loading branch information
mandel-macaque authored Sep 26, 2019
1 parent 253900c commit 2cea356
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 5 deletions.
11 changes: 11 additions & 0 deletions src/appkit.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25336,6 +25336,15 @@ interface NSAccessibilityRadioButton : NSAccessibilityButton {
NSNumber AccessibilityValue { get; }
}

[Mac (10,10)]
[Protocol]
interface NSAccessibilityCheckBox : NSAccessibilityButton
{
[Abstract]
[NullAllowed, Export ("accessibilityValue")]
NSNumber AccessibilityValue { get; }
}

[Mac (10,10)]
[Protocol]
interface NSAccessibilityStaticText : NSAccessibilityElementProtocol {
Expand Down Expand Up @@ -25489,10 +25498,12 @@ interface NSAccessibilityTable : NSAccessibilityGroup {
}

[Mac (10,10)]
[Protocol]
interface NSAccessibilityOutline : NSAccessibilityTable {
}

[Mac (10,10)]
[Protocol]
interface NSAccessibilityList : NSAccessibilityTable {
}

Expand Down
6 changes: 1 addition & 5 deletions tests/xtro-sharpie/macOS-AppKit.ignore
Original file line number Diff line number Diff line change
Expand Up @@ -617,9 +617,6 @@
!missing-pinvoke! NSUpdateDynamicServices is not bound
!missing-pinvoke! NSWindowList is not bound
!missing-pinvoke! NSWindowListForContext is not bound
!missing-protocol! NSAccessibilityCheckBox not bound
!missing-protocol! NSAccessibilityList not bound
!missing-protocol! NSAccessibilityOutline not bound
!missing-protocol! NSAnimatablePropertyContainer not bound
!missing-protocol! NSChangeSpelling not bound
!missing-protocol! NSColorPickingCustom not bound
Expand All @@ -637,7 +634,6 @@
!missing-protocol-conformance! NSMenu should conform to NSAccessibilityElement
!missing-protocol-conformance! NSMenuItem should conform to NSAccessibilityElement
!missing-protocol-conformance! NSOpenGLContext should conform to NSLocking
!missing-protocol-conformance! NSOutlineView should conform to NSAccessibilityOutline
!missing-protocol-conformance! NSPageController should conform to NSAnimatablePropertyContainer
!missing-protocol-conformance! NSPathCell should conform to NSOpenSavePanelDelegate
!missing-protocol-conformance! NSSplitViewItem should conform to NSAnimatablePropertyContainer
Expand Down Expand Up @@ -1193,4 +1189,4 @@
!missing-selector! NSOpenGLView::wantsExtendedDynamicRangeOpenGLSurface not bound

!missing-release-attribute-on-return-value! AppKit.NSDictionaryControllerKeyValuePair AppKit.NSDictionaryController::get_NewObject()'s selector's ('newObject') Objective-C method family ('new') indicates that the native method returns a retained object, and as such a '[return: Release]' attribute is required.
!missing-release-attribute-on-return-value! Foundation.NSObject AppKit.NSObjectController::get_NewObject()'s selector's ('newObject') Objective-C method family ('new') indicates that the native method returns a retained object, and as such a '[return: Release]' attribute is required.
!missing-release-attribute-on-return-value! Foundation.NSObject AppKit.NSObjectController::get_NewObject()'s selector's ('newObject') Objective-C method family ('new') indicates that the native method returns a retained object, and as such a '[return: Release]' attribute is required.

3 comments on commit 2cea356

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Device tests passed on iOS-Beta on Azure DevOps(iOS-Beta): Html Report

🎉 All 70 tests passed 🎉

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Device tests completed (Failed) on TvOS-Beta on Azure DevOps(TvOS-Beta): Html Report 🔥

Test results

2 tests failed, 68 tests passed.

Failed tests

  • monotouch-test/tvOS - device/Debug (dynamic registrar): Failed
  • monotouch-test/tvOS - device/Debug (interpreter): Failed

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.15', Running XM tests on '10.15'' 🔥

Build succeeded
✅ Packages:

API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Xamarin.Mac tests on 10.15 failed: Xamarin.Mac tests on macOS 10.15 failed (introspection) 🔥
🔥 Test run failed 🔥

Test results

1 tests failed, 162 tests passed.

Failed tests

  • MTouch tests/NUnit: Failed (Execution failed with exit code 1)

Please sign in to comment.