Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[release/7.0.3xx] [tools] Always link weakly with NewsstandKit. Fixes #…
…18606. (#18624) It seems that Apple will completely remove the NewsstandKit framework from iOS 17. This poses a problem for existing apps that link with NewsstandKit: they will crash at launch. Solve this by always linking weakly with the NewsstandKit framework; this way any apps that link with it will keep working if the framework ends up being removed by Apple. Fixes #18606. Fixes dotnet/maui#16316. Backport of #18621
- Loading branch information
1cd12c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ API diff for current PR / commit
NET (empty diffs)
iOS: (empty diff detected)tvOS: (empty diff detected)MacCatalyst: (empty diff detected)macOS: (empty diff detected)✅ API diff vs stable
.NET (No breaking changes)
✅ Generator diff
Generator diff is empty
Pipeline on Agent
Hash: 1cd12c4e56aa7c15f30cc6ca821f5a726d778df5 [CI build]
1cd12c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💻 [CI Build] Windows Integration Tests passed 💻
✅ All Windows Integration Tests passed.
Pipeline on Agent
Hash: 1cd12c4e56aa7c15f30cc6ca821f5a726d778df5 [CI build]
1cd12c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌
Failed tests are:
Pipeline on Agent
Hash: 1cd12c4e56aa7c15f30cc6ca821f5a726d778df5 [CI build]
1cd12c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻
✅ All tests on macOS M1 - Mac Ventura (13.0) passed.
Pipeline on Agent
Hash: 1cd12c4e56aa7c15f30cc6ca821f5a726d778df5 [CI build]
1cd12c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📚 [CI Build] Artifacts 📚
Packages generated
View packages
Pipeline on Agent XAMMINI-069.Ventura
Hash: 1cd12c4e56aa7c15f30cc6ca821f5a726d778df5 [CI build]
1cd12c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 [CI Build] Test results 🔥
Test results
❌ Tests failed on VSTS: simulator tests
1 tests crashed, 2 tests failed, 73 tests passed.
Failures
❌ dotnettests tests
Html Report (VSDrops) Download
❌ generator tests
Html Report (VSDrops) Download
❌ interdependent_binding_projects tests
🔥 Failed catastrophically on VSTS: simulator tests - interdependent_binding_projects (no summary found).
Html Report (VSDrops) Download
Successes
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ framework: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 13 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download
Pipeline on Agent
Hash: 1cd12c4e56aa7c15f30cc6ca821f5a726d778df5 [CI build]
1cd12c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻
✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.
Pipeline on Agent
Hash: 1cd12c4e56aa7c15f30cc6ca821f5a726d778df5 [CI build]
1cd12c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 [CI Build] Test results 🚀
Test results
✅ All tests passed on VSTS: simulator tests.
🎉 All 79 tests passed 🎉
Tests counts
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ framework: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 13 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download
Pipeline on Agent
Hash: 1cd12c4e56aa7c15f30cc6ca821f5a726d778df5 [CI build]