Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Timeout to Regex used in the tokenizers #7284

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Nov 2, 2024

No description provided.

@tarekgh tarekgh self-assigned this Nov 2, 2024
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.87%. Comparing base (a9b4212) to head (e294d63).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7284      +/-   ##
==========================================
- Coverage   68.87%   68.87%   -0.01%     
==========================================
  Files        1467     1467              
  Lines      273955   273954       -1     
  Branches    28380    28380              
==========================================
- Hits       188697   188693       -4     
- Misses      77946    77953       +7     
+ Partials     7312     7308       -4     
Flag Coverage Δ
Debug 68.87% <100.00%> (-0.01%) ⬇️
production 63.33% <100.00%> (-0.01%) ⬇️
test 89.18% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...soft.ML.Tokenizers/Model/SentencePieceTokenizer.cs 76.86% <ø> (ø)
...Microsoft.ML.Tokenizers/Model/TiktokenTokenizer.cs 78.28% <100.00%> (ø)
...crosoft.ML.Tokenizers/PreTokenizer/PreTokenizer.cs 92.68% <100.00%> (ø)
...ft.ML.Tokenizers/PreTokenizer/RegexPreTokenizer.cs 87.23% <ø> (ø)

... and 6 files with indirect coverage changes

@tarekgh tarekgh merged commit 5c50319 into dotnet:main Nov 4, 2024
25 checks passed
@tarekgh
Copy link
Member Author

tarekgh commented Nov 4, 2024

Thanks @stephentoub for your feedback and review!

tarekgh added a commit to tarekgh/machinelearning that referenced this pull request Nov 8, 2024
* Add Timeout to Regex used in the tokenizers

* Address the feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants