-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Timeout to Regex used in the tokenizers #7284
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7284 +/- ##
==========================================
- Coverage 68.87% 68.87% -0.01%
==========================================
Files 1467 1467
Lines 273955 273954 -1
Branches 28380 28380
==========================================
- Hits 188697 188693 -4
- Misses 77946 77953 +7
+ Partials 7312 7308 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Nov 2, 2024
Open
stephentoub
reviewed
Nov 2, 2024
stephentoub
reviewed
Nov 2, 2024
stephentoub
reviewed
Nov 2, 2024
stephentoub
reviewed
Nov 2, 2024
stephentoub
approved these changes
Nov 4, 2024
Thanks @stephentoub for your feedback and review! |
tarekgh
added a commit
to tarekgh/machinelearning
that referenced
this pull request
Nov 8, 2024
* Add Timeout to Regex used in the tokenizers * Address the feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.