Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the components governance file cgmanifest.json for tokenizer's vocab files #7283

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Oct 31, 2024

No description provided.

@tarekgh
Copy link
Member Author

tarekgh commented Oct 31, 2024

CC @GrabYourPitchforks

@tarekgh
Copy link
Member Author

tarekgh commented Oct 31, 2024

@ericstj I added the component governance file cgmanifest.json in the root of the repo. We can store it anywhere in the repo if we want to. Please let me know if you are ok with that.

CC @michaelgsharp

cgmanifest.json Show resolved Hide resolved
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.86%. Comparing base (a9b4212) to head (c2171cd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7283      +/-   ##
==========================================
- Coverage   68.87%   68.86%   -0.01%     
==========================================
  Files        1467     1467              
  Lines      273955   273954       -1     
  Branches    28380    28380              
==========================================
- Hits       188697   188671      -26     
- Misses      77946    77973      +27     
+ Partials     7312     7310       -2     
Flag Coverage Δ
Debug 68.86% <100.00%> (-0.01%) ⬇️
production 63.32% <ø> (-0.02%) ⬇️
test 89.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...Microsoft.ML.Tokenizers/Model/TiktokenTokenizer.cs 78.28% <ø> (ø)
...oft.ML.Tokenizers.Data.Tests/TokenizerDataTests.cs 100.00% <ø> (ø)
...est/Microsoft.ML.Tokenizers.Tests/TiktokenTests.cs 98.98% <100.00%> (ø)

... and 9 files with indirect coverage changes

@tarekgh
Copy link
Member Author

tarekgh commented Nov 1, 2024

/ba-g the failed test is recognized by the build analysis but somehow the build analysis still complaining that helix returned failure.

@tarekgh tarekgh merged commit 7cce753 into dotnet:main Nov 1, 2024
23 of 25 checks passed
tarekgh added a commit to tarekgh/machinelearning that referenced this pull request Nov 8, 2024
…vocab files (dotnet#7283)

* Add the governance file cgmanifest.json for tokenizer's vocab files

* Address the feedback

* apply more schema requirements on the doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants