Update wording in LDA docs #7253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
michaelgsharp
approved these changes
Oct 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7253 +/- ##
==========================================
+ Coverage 68.77% 68.78% +0.01%
==========================================
Files 1462 1463 +1
Lines 272261 272288 +27
Branches 28176 28177 +1
==========================================
+ Hits 187254 187304 +50
+ Misses 77764 77741 -23
Partials 7243 7243
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Failure downloading tokenizer vocab file |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the wording mentioning countries. This is actually a quote, but it need not mention
countries- the actual source of this quote has since been updated.https://en.wikipedia.org/w/index.php?title=Earth_Day&oldid=824511329 (which was pulled from an old version of earthday.org).
I didn't bother updating the values in the comment - I'm not sure if they need to be accurate to get the point across. @michaelgsharp if you think they should be updated please let me know and help me recompute them.