Fix marking of annotations on complex type hierarchies #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code didn't take into account the fact that applying annotations can lead to marking of additional types which will interact with the cache data structure which is used to drive the application of annotations. This change adds several new test cases with complex hierarchies and interactions and implements fixes in the code for those.
MichalStrehovsky
approved these changes
Apr 17, 2021
|
I filled #1976 for scenarios that use DynamicDependency, I don't think this should gate this PR since a complete different scenario that has the old behavior of not keep enough stuff. |
agocke
added a commit
to agocke/runtime
that referenced
this pull request
Apr 22, 2021
This fix is necessary for dotnet#51237 to work properly. Otherwise, the linker may crash when analyzing certain patterns.
7 tasks
mmitche
pushed a commit
to dotnet/runtime
that referenced
this pull request
Apr 22, 2021
* Include linker fix from dotnet/linker#1972 This fix is necessary for #51237 to work properly. Otherwise, the linker may crash when analyzing certain patterns. * Fix EventSource trimmer warning (#51237) * eh fix * test change that inadvertently got checked in earlier * Suppresses the trimmer warning on TypeAnalysis ctor * Incorporating FB * Update src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs Co-authored-by: Eric Erhardt <[email protected]> * Update src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs Co-authored-by: Eric Erhardt <[email protected]> * Update src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs Co-authored-by: Eric Erhardt <[email protected]> * Fix DynamicDependency as per PR feedback * an earlier change got reverted * fixed proj file netcore app condition check * fixed NETCORE_ENGINEERING_TELEMETRY build failures * fixeing another NETCORE_ENGINEERING_TELEMETRY build failures * Adding RequiresUnreferencedCode to TypeAnalysis ctor instead of suppressing the warning to get FB, not fully fixed * PR FB and suppressing warnings for safe calls * propagated the warning all the way up * CI build break fix for one file * excluding NativeRTEventSrc from being build in a project * Missed couple of supppressions on NativeRTEventSrc * build break fixes * Trimmer warning fix related to EventSource manifest creation * incorporate fb * fix build break in some configs * comment feedback * build break Co-authored-by: Eric Erhardt <[email protected]> (cherry picked from commit ddaa1c3) Co-authored-by: Lakshan Fernando <[email protected]>
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
…#1972) The original code didn't take into account the fact that applying annotations can lead to marking of additional types which will interact with the cache data structure which is used to drive the application of annotations. This change adds several new test cases with complex hierarchies and interactions and implements fixes in the code for those. Commit migrated from dotnet/linker@0e2e95e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code didn't take into account the fact that applying annotations can lead to marking of additional types which will interact with the cache data structure which is used to drive the application of annotations.
This change adds several new test cases with complex hierarchies and interactions and implements fixes in the code for those.
Fixes #1969