Codefixer should not use CultureInfo.CurrentUICulture

[vitek-karas]

This is all about dotnet/roslyn#66566.

Once there's the right API to use, the code fixer should switch to it.

[bradwilson]

Analyzers are strongly suggested to get their UI from the compiler switch by using LocalizableResourceString, because the context in which they're executed is the compiler.

Fixers are not executed in the context of the compiler. They're executed in the context of a UI like Visual Studio or VS Code. As such, using CultureInfo.CurrentCulture should not have been prohibited by RS1035, and is actually the correct behavior to align with being displayed in a UI context. (This is what I've been told by people on the Roslyn team after discovering RS1035 raising issues in fixers.)

See: dotnet/roslyn-analyzers#7086 (comment)

[vitek-karas]

/fyi: @sbomer

[dotnet-policy-service]

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

[sbomer]

We are following the guidance, so this issue only tracks removing this suppression for RS1035 once it is no longer produced for code fixers:

runtime/src/tools/illink/src/ILLink.CodeFix/UnconditionalSuppressMessageCodeFixProvider.cs

Lines 47 to 49 in 9550d3b

	#pragma warning disable RS1035 // Do not use APIs banned for analyzers - https://github.com/dotnet/linker/issues/3197
	var ruleTitle = diagnostic.Descriptor.Title.ToString (CultureInfo.CurrentUICulture);
	#pragma warning restore RS1035 // Do not use APIs banned for analyzers